mintstick New Progress Bar [Code Submission]

Contribute code & patches
Forum rules
No support questions here please

mintstick New Progress Bar [Code Submission]

Postby inhuman4 on Tue Feb 12, 2013 4:48 am

Hi all,

First, thanks for creating Linux Mint, it is by far my favorite distro :D

Today I played with mintstick because I was going to update my laptop. I discovered that the progress bar does not show the transfer rate like I would prefer it did. So I played around with the code to make it happen. The progress bar now shows and updates "%complete KB/s" instead of the source and destination like before. Which I think looks a fair bit nicer.

I've made a github fork of it here: http://github.com/tbehan/mintstick

The thing is, I'm rather new at both python and contributing to an open-source project so I was hoping someone would be willing to take a look at it before I do a pull request. It's just a cosmetic change so it shouldn't cause any issues and the code change is very small.

Any feedback is greatly appreciated.
User avatar
inhuman4
Level 1
Level 1
 
Posts: 4
Joined: Sun Oct 17, 2010 11:22 pm
Location: Toronto, Canada

Linux Mint is funded by ads and donations.
 

Re: mintstick New Progress Bar [Code Submission]

Postby inhuman4 on Tue Feb 12, 2013 11:36 am

Just a little update.

I also discovered that mintstick was causing Xorg to run one of my CPUs at 100% on my LMDE system. I think this is because it was updating the progress bar every time 1kb was written which is way too fast. I have changed things a bit so that this doesn't happen anymore.
User avatar
inhuman4
Level 1
Level 1
 
Posts: 4
Joined: Sun Oct 17, 2010 11:22 pm
Location: Toronto, Canada

Re: mintstick New Progress Bar [Code Submission]

Postby xenopeek on Tue Feb 12, 2013 4:56 pm

Best way to get it reviewed is probably by doing a pull request. Or you can visit the Linux Mint and contributing developers on the IRC, see if somebody there will want to have a look. To join the IRC open XChat or Quassel (for KDE) from the Internet category in your menu, then type:
Code: Select all
/join #linuxmint-dev

And you will join the development chat channel. You're welcome to stop in, say hi, and ask for some advice also there on how best to get your code reviewed :wink:
Image
Linux Mint 14 Nadia / 64-bit / Cinnamon
User avatar
xenopeek
Level 20
Level 20
 
Posts: 10505
Joined: Wed Jul 06, 2011 3:58 am
Location: The Netherlands


Return to Code & Patches

Who is online

Users browsing this forum: No registered users and 1 guest