[fixed 3.7.9] mintUpdate 3.2.2 - incorrect package levelling

[emorrp1]

When the mint elyssa repos are down, the dangerous (lvl 4/5) packages from Ubuntu (the -updates repo) are incorrectly marked as lvl 3, see viewtopic.php?f=34&t=26836&p=162431#p162431 Unknown whether this affects felicia+, can anyone confirm for these mints?

[Husse]

mintUpdate first downloads a list of security levels
/usr/lib/linuxmint/mintUpdate/tmp/rules
Everything not mentioned there gets level 3
I just checked and the rules file was empty
I then started mintUpdate and the rules file had the proper content
So updating while our repos are down could be a bit hazardous
I would not call it a bug, but I'll ask Clem to modify mintUpdate so we don't get an empty file
Thanks for letting us know

[emorrp1]

Ok, so now I've had the chance to examine the source code, and confirm the same thing happens if you're simply not connected to the internet, and also in mintUpdate 3.7.7 (Gloria)

The issue is on line 322 of mintUpdate.py where the condition always evaluates to false, since an empty file is written on line 310, hence the else clause is always executed, removing the backup copy of the rules file too.

Steps to reproduce:
1) ensure correct connection to internet
2) run mintUpdate, check the log has "++ Successfully downloaded new safety rules"... in it
3) verify the non-empty files /usr/lib/linuxmint/mintUpdate/tmp/rules and /usr/lib/linuxmint/mintUpdate/rules.old
4) disconnect the internet
5) run mintUpdate, check the log has "-- Failed to download new safety rules:"... in it, but not "-- Could not download safety rules"
6) verify the empty files above.

[emorrp1]

reported to launchpad: https://bugs.launchpad.net/linuxmint/+bug/399276

[Husse]

I have a feeling Clem has been on to this...

[emorrp1]

indeed, it was clem who filed that bug report